[prev in list] [next in list] [prev in thread] [next in thread]
List: git
Subject: Re: [PATCH] send-email: Net::SMTP::starttls was introduced in v3.01 (Re: [BUG] git-send-email broken
From: Jonathan Nieder <jrnieder () gmail ! com>
Date: 2017-05-31 23:01:56
Message-ID: 20170531230156.GE81679 () aiede ! mtv ! corp ! google ! com
[Download RAW message or body]
Eric Biggers wrote:
> On Wed, May 31, 2017 at 03:44:15PM -0700, Jonathan Nieder wrote:
>> Subject: send-email: Net::SMTP::starttls was introduced in v3.01
>>
>> We cannot rely on the starttls method being present in the copy
>> of Net::SMTP shipped with perl until v5.21.5~169 (Update libnet to
>> CPAN version 3.01, 2014-10-10).
>>
>> Reported-by: Brandon Williams <bmwill@google.com>
>> Reported-by: Eric Biggers <ebiggers3@gmail.com>
>> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
>> ---
[...]
>> +++ b/git-send-email.perl
>> @@ -1354,7 +1354,7 @@ EOF
>> }
>>
>> require Net::SMTP;
>> - my $use_net_smtp_ssl = version->parse($Net::SMTP::VERSION) < version->parse("1.28");
>> + my $use_net_smtp_ssl = version->parse($Net::SMTP::VERSION) < version->parse("3.01");
>> $smtp_domain ||= maildomain();
>>
>> if ($smtp_encryption eq 'ssl') {
>> --
>
> Yes, that solves the problem for me.
Thanks. Mining through https://github.com/gbarr/perl-libnet, I find
$ git log -Sstarttls
[...]
commit b4a7a274a7fe5344c154abc4b3fdd7c446d36370
Author: Steffen Ullrich <Steffen_Ullrich@genua.de>
Date: Fri May 9 23:15:48 2014 +0200
SSL and IPv6 support for Net::SMTP
$ git show b4a7a274a7fe5344c154abc4b3fdd7c446d36370
[...]
diff --git a/Net/SMTP.pm b/Net/SMTP.pm
index 705b5c5..fcc124f 100644
--- a/Net/SMTP.pm
+++ b/Net/SMTP.pm
@@ -18,7 +18,31 @@ use Net::Config;
$VERSION = "2.33";
[...]
$ git log -p --ancestry-path b4a7a274a7fe5344c154abc4b3fdd7c446d36370..HEAD -- Net/SMTP.pm
[...]
commit 67b37d5c7118f9af50e5a5a00c242992caba3b8d
Author: Steve Hay <steve.m.hay@googlemail.com>
Date: Mon Jun 2 14:13:55 2014 +0100
Bump $VERSION in changed modules
diff --git a/Net/SMTP.pm b/Net/SMTP.pm
index 4496f6f..9dfaadf 100644
--- a/Net/SMTP.pm
+++ b/Net/SMTP.pm
@@ -16,7 +16,7 @@ use IO::Socket;
use Net::Cmd;
use Net::Config;
-$VERSION = "2.34";
+$VERSION = "2.35";
# Code for detecting if we can use SSL
my $ssl_class = eval {
I think 2.35 is the correct minimum version.
Jonathan
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic