[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH v1 09/19] config: add git_config_get_max_percent_split_change()
From:       Christian Couder <christian.couder () gmail ! com>
Date:       2016-10-29 22:24:54
Message-ID: CAP8UFD3kPVRdubHEsbKbUuxhMDjWNz6y_ANLBB+4Au76PJ3U6w () mail ! gmail ! com
[Download RAW message or body]

On Tue, Oct 25, 2016 at 12:06 PM, Duy Nguyen <pclouds@gmail.com> wrote:
> On Sun, Oct 23, 2016 at 4:26 PM, Christian Couder
> <christian.couder@gmail.com> wrote:
>> This new function will be used in a following commit to get the
>> +int git_config_get_max_percent_split_change(void)
>> +{
>> +       int val = -1;
>> +
>> +       if (!git_config_get_int("splitindex.maxpercentchange", &val)) {
>> +               if (0 <= val && val <= 100)
>> +                       return val;
>> +
>> +               error("splitindex.maxpercentchange value '%d' "
>
> We should keep camelCase form for easy reading. And wrap this string with _().

Ok, it will be in the next version.

Thanks,
Christian.
[prev in list] [next in list] [prev in thread] [next in thread]