[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH 1/5] pretty: allow formatting DATE_SHORT
From:       Jacob Keller <jacob.keller () gmail ! com>
Date:       2016-09-30 22:04:54
Message-ID: CA+P7+xpWi_qgRTVmLf-bJq1mn7dW0Hf6544wHsOgFniDQyHo2Q () mail ! gmail ! com
[Download RAW message or body]

On Fri, Sep 30, 2016 at 3:56 AM, SZEDER Gábor <szeder@ira.uka.de> wrote:
>> On Thu, Sep 29, 2016 at 1:33 AM, Jeff King <peff@peff.net> wrote:
>> > There's no way to do this short of "%ad" and --date=short,
>> > but that limits you to having a single date format in the
>> > output.
>> >
>> > This would possibly be better done with something more like
>> > "%ad(short)".
>> >
>> > Signed-off-by: Jeff King <peff@peff.net>
>> > ---
>> >  pretty.c | 3 +++
>> >  1 file changed, 3 insertions(+)
>> >
>> > diff --git a/pretty.c b/pretty.c
>> > index 493edb0..c532c17 100644
>> > --- a/pretty.c
>> > +++ b/pretty.c
>> > @@ -727,6 +727,9 @@ static size_t format_person_part(struct strbuf *sb, char part,
>> >         case 'I':       /* date, ISO 8601 strict */
>> >                 strbuf_addstr(sb, show_ident_date(&s, DATE_MODE(ISO8601_STRICT)));
>> >                 return placeholder_len;
>> > +       case 's':
>> > +               strbuf_addstr(sb, show_ident_date(&s, DATE_MODE(SHORT)));
>> > +               return placeholder_len;
>> >         }
>> >
>> >  skip:
>> > --
>> > 2.10.0.566.g5365f87
>> >
>>
>> Nice. I use date=short in some of my aliases and switching to this is
>> nicer. I assume this turns into "%(as)"?
>>
>> What about documenting this in  pretty-formats.txt?
>
> Here you go :)
>
>   http://public-inbox.org/git/1444235305-8718-1-git-send-email-szeder@ira.uka.de/
>

Nice, thanks!

Regards,
Jake
[prev in list] [next in list] [prev in thread] [next in thread]