From git Sun Jul 03 06:49:38 2016 From: Christopher Layne Date: Sun, 03 Jul 2016 06:49:38 +0000 To: git Subject: Re: [PATCH] git-svn: clone: Fail on missing url argument Message-Id: <6A207591-312F-4C62-8C69-2742E44146F4 () anodized ! com> X-MARC-Message: https://marc.info/?l=git&m=146752900108235 > On Jul 2, 2016, at 2315 PT, Eric Wong wrote: >> sub cmd_clone { >> my ($url, $path) = @_; >> - if (!defined $path && >> + if (!$url) { >> + die "SVN repository location required ", >> + "as a command-line argument\n"; > > "as a command-line argument" seems like an unnecessary phrase, > but I see we use it elsewhere; so it's fine here. > > I might be tempted to queue up a separate patch > to eliminate this extra statement from the rest of git-svn, > though. Not sure if others feel the same way. I basically went with the same logic/error message that cmd_init() was using a couple of lines down in an attempt to stay consistent: 527 sub cmd_init { 528 if (defined $_stdlayout) { 529 $_trunk = 'trunk' if (!defined $_trunk); 530 @_tags = 'tags' if (! @_tags); 531 @_branches = 'branches' if (! @_branches); 532 } 533 if (defined $_trunk || @_branches || @_tags) { 534 return cmd_multi_init(@_); 535 } 536 my $url = shift or die "SVN repository location required ", 537 "as a command-line argument\n"; 538 $url = canonicalize_url($url); 539 init_subdir(@_); 540 do_git_init_db(); 541 542 if ($Git::SVN::_minimize_url eq 'unset') { 543 $Git::SVN::_minimize_url = 0; 544 } 545 546 Git::SVN->init($url); 547 } -cl -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html