[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCHv2 4/5] submodule--helper, module_clone: always operate on absolute paths
From:       Stefan Beller <sbeller () google ! com>
Date:       2016-03-31 23:08:02
Message-ID: CAGZ79kb4xOraKCODeLNqHCCdpdG=2aYofVsu0MRQteBozCsswQ () mail ! gmail ! com
[Download RAW message or body]

On Thu, Mar 31, 2016 at 3:59 PM, Stefan Beller <sbeller@google.com> wrote:
>
> Further checking reveals any caller uses it with
>
>     desired= xstrdup(absolute_path(my_argument));
>
> We are loosing memory of the strbuf here. so if I we'd
> take the diff above we can also get rid of all the xstrdups
> at the callers. For now I will adhere to all other callers and use
> xstrdup(absolute_path(...) here too.

Actually there is only two occurrences of xstrdup in builtin/clone.c
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]