[prev in list] [next in list] [prev in thread] [next in thread]
List: git
Subject: Re: [PATCH v3 16/25] commit_lock_file(): die() if called for unlocked lockfile object
From: Johannes Sixt <j.sixt () viscovery ! net>
Date: 2014-04-15 6:49:57
Message-ID: 534CD695.20306 () viscovery ! net
[Download RAW message or body]
Am 4/14/2014 15:54, schrieb Michael Haggerty:
> diff --git a/lockfile.c b/lockfile.c
> index 664b0c3..1453a7a 100644
> --- a/lockfile.c
> +++ b/lockfile.c
> @@ -292,6 +292,9 @@ int commit_lock_file(struct lock_file *lk)
> if (lk->fd >= 0 && close_lock_file(lk))
> return -1;
>
> + if (!lk->filename[0])
> + die("BUG: attempt to commit unlocked object");
> +
Shouldn't this be the first thing to check after entering the function?
> strcpy(result_file, lk->filename);
> /* remove ".lock": */
> result_file[strlen(result_file) - LOCK_SUFFIX_LEN] = 0;
>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic