[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH] Enable index-pack threading in msysgit.
From:       Karsten Blees <karsten.blees () gmail ! com>
Date:       2014-03-21 18:40:19
Message-ID: 532C8793.8050202 () gmail ! com
[Download RAW message or body]

Am 20.03.2014 02:25, schrieb Duy Nguyen:
> On Thu, Mar 20, 2014 at 4:35 AM, Stefan Zager <szager@chromium.org> wrote:
> > This adds a Windows implementation of pread.  Note that it is NOT
> > safe to intersperse calls to read() and pread() on a file
> > descriptor.  According to the ReadFile spec, using the 'overlapped'
> > argument should not affect the implicit position pointer of the
> > descriptor.  Experiments have shown that this is, in fact, a lie.
> > 
> > To accomodate that fact, this change also incorporates:
> > 
> > http://article.gmane.org/gmane.comp.version-control.git/196042
> > 
> > ... which gives each index-pack thread its own file descriptor.
> 
> If the problem is mixing read() and pread() then perhaps it's enough to do
> 
> output_fd = dup(output_fd);
> 

Unfortunately not, dup() / DuplicateHandle() just opens another handle to the same \
file object (i.e. sharing the same file position).

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[prev in list] [next in list] [prev in thread] [next in thread]