[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH v2 09/11] reflog-walk.c: use ALLOC_GROW() instead of inline code
From:       Junio C Hamano <gitster () pobox ! com>
Date:       2014-02-28 19:06:51
Message-ID: xmqqbnxrukdw.fsf () gitster ! dls ! corp ! google ! com
[Download RAW message or body]

Duy Nguyen <pclouds@gmail.com> writes:

> On Fri, Feb 28, 2014 at 4:46 PM, Dmitry S. Dolzhenko
> <dmitrys.dolzhenko@yandex.ru> wrote:
>> Affected functions: read_one_reflog(), add_commit_info()
>
> We can usually see this from @@ line so it's not really needed to
> describe. Same comment for a few other patches.

Not everybody always reads "git log" with "-p".  It is good to see
what are changed mentioned somewhere.

I prefer to see full sentences, though ;-)

	Subject: reflog-walk.c: use ALLOC_GROW()

	read_one_reflog() and add_commit_info() open-codes reallocation;
        use ALLOC_GROW() instead.

or something.  But that is minor.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]