[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: RFE: support change-id generation natively
From:       Johannes Sixt <j.sixt () viscovery ! net>
Date:       2013-10-25 6:37:28
Message-ID: 526A11A8.90200 () viscovery ! net
[Download RAW message or body]

Am 10/24/2013 22:04, schrieb Junio C Hamano:
> Johannes Sixt <j.sixt@viscovery.net> writes:
>> That said, I don't think that --change-id option that the user must not
>> forget to use is any better than a hook that the user must not forget to
>> install.
> 
> That is why I said this in my first response to this thread:
> 
>>> ...  We may even want to
>>> introduce commit.changeId boolean configuration variable if we did
>>> so.

That's only slightly different and still "must not forget to set".

But I am more concerned that a non-volatile change-id is totally outside
the Git data model. After we have git commit --change-id, what will be the
next requests for enhancement? 'git merge' and 'git cherry-pick' take a
change-id? Where will it end?

We could ship a git-gerrit-commit wrapper script in contrib that adds the
change-id and that people can alias their 'git ci' to globally or on a
per-repo basis.

-- Hannes
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]