[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH] git send-email: include [anything]-by: signatures
From:       "Michael S. Tsirkin" <mst () redhat ! com>
Date:       2013-08-31 19:22:50
Message-ID: 20130831192250.GA3823 () redhat ! com
[Download RAW message or body]

On Mon, Aug 26, 2013 at 07:57:47PM +0300, Michael S. Tsirkin wrote:
> Consider [anything]-by: a valid signature.
> This includes Tested-by: Acked-by: Reviewed-by: etc.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Ping.
Any opinion on whether this change is acceptable?

> ---
>  git-send-email.perl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/git-send-email.perl b/git-send-email.perl
> index ecbf56f..bb9093b 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1359,7 +1359,7 @@ foreach my $t (@files) {
>  	# Now parse the message body
>  	while(<$fh>) {
>  		$message .=  $_;
> -		if (/^(Signed-off-by|Cc): (.*)$/i) {
> +		if (/^([A-Za-z-]*-by|Cc): (.*)$/i) {
>  			chomp;
>  			my ($what, $c) = ($1, $2);
>  			chomp $c;
> -- 
> MST
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]