[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH] CYGWIN: Use a TCP socket for pipe()
From:       Junio C Hamano <gitster () pobox ! com>
Date:       2013-06-30 22:56:35
Message-ID: 7vwqpbi4ws.fsf () alter ! siamese ! dyndns ! org
[Download RAW message or body]

Torsten Bögershausen <tboegi@web.de> writes:

> I testet "rj/cygwin-remove-cheating-lstat" with the "socket pipe" on top:
> no hanging.
>
> Then I run "rj/cygwin-remove-cheating-lstat" without "socket pipe",
> (or in other words git.git/pu):
> No hanging.

So an immediate conclusion is that we can forget about this patch?

> So at the moment I don't have any problems to report for cygwin, which is good.
>
> And it looks as if "rj/cygwin-remove-cheating-lstat" prevents the "hanging",
> so there is another +1 to keep it and move it into next.

Ramsay started a "mark places we call lstat() when we do not really
need fully correct lstat" topic, and I think it may be a sane
direction to go, as long as the helper function's semantic is
clearly defined.

It would be worth seeing where it leads us, before ripping that
"cheating and incomplete lstat out, I think.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]