[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH] submodule update: when using recursion, show full path
From:       Jens Lehmann <Jens.Lehmann () web ! de>
Date:       2013-03-04 0:06:08
Message-ID: 5133E570.7030507 () web ! de
[Download RAW message or body]

Am 02.03.2013 20:44, schrieb William Entriken:
> Previously when using update with recursion, only the path for the
> inner-most module was printed. Now the path is printed relative to
> the directory the command was started from. This now matches the
> behavior of submodule foreach.
> 
> Signed-off-by: William Entriken <github.com@phor.net>

Thanks, this patch cleanly applies against maint and addresses all
issues from the previous rounds.

Acked-by: Jens Lehmann <Jens.Lehmann@web.de>

Junio, could you please squash in this additional test?

--------8<-------
diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh
index feaec6c..70528b7 100755
--- a/t/t7406-submodule-update.sh
+++ b/t/t7406-submodule-update.sh
@@ -612,7 +612,8 @@ test_expect_success 'submodule update places git-dir in superprojects git-dir re
 	rm -rf super_update_r2 &&
 	git clone super_update_r super_update_r2 &&
 	(cd super_update_r2 &&
-	 git submodule update --init --recursive &&
+	 git submodule update --init --recursive >actual &&
+	 test_i18ngrep "Submodule path .submodule/subsubmodule.: checked out" actual &&
 	 (cd submodule/subsubmodule &&
 	  git log > ../../expected
 	 ) &&
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]