[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH 2/3] revision: add --grep-reflog to filter commits by reflog messages
From:       Nguyen Thai Ngoc Duy <pclouds () gmail ! com>
Date:       2012-09-30 3:45:30
Message-ID: CACsJy8DC=rpuFQbKG9MUh3Aknf6zxJJpww+XoCYki5tu3SDF4w () mail ! gmail ! com
[Download RAW message or body]

On Sun, Sep 30, 2012 at 2:11 AM, Junio C Hamano <gitster@pobox.com> wrote:
> How about squashing this in?  I've future-proofed commit_match() a
> bit while at it; it would be cleaner to add new fake headers if the
> function is done this way.

Sure. It looks good to me.

> --- a/Documentation/rev-list-options.txt
> +++ b/Documentation/rev-list-options.txt
> @@ -56,8 +56,8 @@ endif::git-rev-list[]
>         Limit the commits output to ones with reflog entries that
>         match the specified pattern (regular expression). With
>         more than one `--grep-reflog`, commits whose reflog message
> -       matches any of the given patterns are chosen. Ignored unless
> -       `--walk-reflogs` is given.
> +       matches any of the given patterns are chosen.  It is an
> +       error to use this option unless `--walk-reflogs` is in use.

We could even drop the part about --walk-reflogs. Users will soon
figure it out when they try it.
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]