[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH] run-command: treat inaccessible directories as ENOENT
From:       "Frans Klaver" <fransklaver () gmail ! com>
Date:       2012-03-30 20:22:39
Message-ID: op.wbz2v2k60aolir () keputer
[Download RAW message or body]

On Fri, 30 Mar 2012 18:21:29 +0200, Junio C Hamano <gitster@pobox.com>  
wrote:

> Frans Klaver <fransklaver@gmail.com> writes:
>
>> isn't it rather more sensible from a unit-test perspective to see
>> if start_command returns 127 instead of 128 in this specific case?
>
>
> You are welcome to add another test that checks lower level  
> implementation
> detail, but this specific test is to make sure the gripe "Why does git
> deny my aliases when I have inaccessible directory on my PATH?" will  
> never
> come back.

I think I didn't word carefully enough there. I didn't mean to dispute the  
use of the test. The test I proposed would make sense in t0061, but I  
would rather have expected the test in Jeff's patch in a tests that  
specifically targets aliases. It would be less surprising, wouldn't it?  
The fact that git goes through start_command before doing aliases is  
merely an implementation detail, from my point of view.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]