[prev in list] [next in list] [prev in thread] [next in thread]
List: git
Subject: [PATCH] compat/getpass.c: Fix a sparse "symbol not declared" warning
From: Ramsay Jones <ramsay () ramsay1 ! demon ! co ! uk>
Date: 2011-11-30 20:54:27
Message-ID: 4ED69803.6070508 () ramsay1 ! demon ! co ! uk
[Download RAW message or body]
In particular, sparse complains as follows:
SP compat/getpass.c
compat/getpass.c:5:6: warning: symbol 'getpass_echo' was not \
declared. Should it be static?
In order to suppress the warning, we include the getpass.h header
file which contains an appropriate extern declaration.
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Jeff,
When you next re-roll your most recent credentials/getpass series, could
you please squash this patch in. (This patch was against pu @ 1cc922af,
but I guess you need to apply a similar patch to commit 8eca119c "stub out
getpass_echo function", 27-11-2011 instead)
Thanks!
ATB,
Ramsay Jones
compat/getpass.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/compat/getpass.c b/compat/getpass.c
index b5bd1dd..a145d27 100644
--- a/compat/getpass.c
+++ b/compat/getpass.c
@@ -1,4 +1,5 @@
#include "../git-compat-util.h"
+#include "getpass.h"
#ifdef HAVE_DEV_TTY
--
1.7.7
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic