[prev in list] [next in list] [prev in thread] [next in thread]
List: git
Subject: Re: [PATCH] Add support in sample hook script for denying annotated
From: Jonathan Nieder <jrnieder () gmail ! com>
Date: 2010-10-31 20:24:33
Message-ID: 20101031202433.GB21240 () burratino
[Download RAW message or body]
Hi,
Boyd Stephen Smith Jr. wrote:
> Signed-off-by: "Boyd Stephen Smith Jr." <bss@iguanasuicide.net>
> ---
> templates/hooks--update.sample | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> In one project I'm in we are using a centralized Git repository that many
> developers have access to. As such, we want to prevent tags from being
> created by push operations and have them created by the administrators.
>
> This is a modification to the sample update hook to allow this to simply be
> a configuration option.
This kind of justification belongs above the "---", I think.
No opinion on the functionality itself. Just:
> --- a/templates/hooks--update.sample
> +++ b/templates/hooks--update.sample
> @@ -7,6 +7,9 @@
> #
> # Config
> # ------
> +# hooks.allowannotated
> +# This boolean sets whether annotated tags will be allowed into the
> +# repository. By default they won't be.
hooks.denyannotated (defaulting to false) would be more consistent
with hooks.denycreatebranch, no?
Or maybe hooks.denycreatetag --- a situation in which unannotated
tags should be allowed but annotated denied seems hard to imagine.
Hope that helps,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic