[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH] rev-parse: fix --parse-opt --keep-dashdash
From:       Junio C Hamano <gitster () pobox ! com>
Date:       2010-07-07 21:41:33
Message-ID: 7vr5jfrmuq.fsf () alter ! siamese ! dyndns ! org
[Download RAW message or body]

Uwe Kleine-König  <u.kleine-koenig@pengutronix.de> writes:

> The ?: operator has a lower priority than |, so the implicit associativity
> made the 6th argument of parse_options be PARSE_OPT_KEEP_DASHDASH if
> keep_dashdash was true discarding PARSE_OPT_STOP_AT_NON_OPTION and
> PARSE_OPT_SHELL_EVAL.

Wow, this is an age-old breakage dating back to 6e0800e (parse-opt: make
PARSE_OPT_STOP_AT_NON_OPTION available to git rev-parse, 2009-06-14) that
dates back to the very original --stop-at-non-option patch, isn't it?

I wonder if I should issue an updated maintenance release v1.6.4.5 ;-)

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]