[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH 0/3] git-instaweb: Support for 'plackup' and
From:       Petr Baudis <pasky () suse ! cz>
Date:       2010-05-31 21:15:09
Message-ID: 20100531211509.GB27342 () machine ! or ! cz
[Download RAW message or body]

On Fri, May 28, 2010 at 09:11:22PM +0200, Jakub Narebski wrote:
> This series adds support for 'plackup' web server (PSGI/Plack based
> server script) to git-instaweb.  Because the web server (by default
> pure-Perl HTTP::Server::PSGI aka PLACK_SERVER=Standalone) can take a
> while to start, it required adding waiting for web server to be ready
> before starting web browser.
> 
> This series also contains somewhat unrelated fixup, namely that
> git-instaweb removes pidfile after stopping web server.  This is
> probably important only to web servers which do not have daemon mode,
> and are "daemonized" (which includes generating pidfile) by
> git-instaweb itself.

I did not test the series, but looking over it, all appears sane, so

Acked-by: Petr Baudis <pasky@suse.cz>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]