[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH] Provide a window icon on Windows platforms
From:       Pat Thoyts <patthoyts () googlemail ! com>
Date:       2009-12-31 23:47:04
Message-ID: a5b261830912311547n37c113avcc5089bd15c17bbe () mail ! gmail ! com
[Download RAW message or body]

2009/12/31 Kirill <kirillathome@gmail.com>:
> Unfortunately, I have to insist on my patch :)
> 
> > -----Original Message-----
> > From: Pat Thoyts [mailto:patthoyts@googlemail.com]
> > Sent: Thursday, December 31, 2009 4:12 PM
> 
> > 2009/12/31 Kirill <kirillathome@gmail.com>:
> > > Looks like 37871b73 by Giuseppe Bilotta does not work very well on
> > > Windows. Instead of a former tcl/tk icon, the window has a black
> > > square as an icon.
> > 
> > I've been using versions of gitk on Windows with that patch since it
> > was applied in March and it has been fine. On Windows XP and Windows
> > 7. So there is more to this than you are telling. Are you using
> > windows via remote desktop?
> You're absolutely right about *unintentional* withdrawal of facts in my original \
> message, but no, I'm not using Remote Desktop. However, my XP SP3 has 16-bit colors \
> and apparently 8.5.7 can't display those photos correctly in this case either. Most \
> probable reason why the issue was first discovered in Remote Desktop is because \
> most of RDP sessions are limited to 16-bit colors. 
> > If so, this requires an updated Tk and not a patch to gitk -
> > tk 8.5.8 should be ok if this is the problem.
> Unfortunately, the situation is improved with 8.5.8, but definitely not resolved \
> (tested on msysGit devel branch). The sequence image create photo && wm iconphoto \
> on 16-bit displays in XP SP3 renders the background black, not transparent. The \
> fact that I'm using Classic color schema may play some role too. I'd speculate that \
> 8.5.8 on Windows 7 (admittedly, it's much harder to switch to 16-bit colors there) \
> may have exactly the same issue, given that 8.5.7 has exactly the same symptoms.

No - it will be the use of 16bit color. Classic gets used a lot, 16
bit colour - well, you might be the only one now so such a system has
limited testing.

> 
> Is there a way to replace the "simplistic"
> 
> if {$::tcl_platform(platform) eq {windows}}
> 
> with something more elaborate that takes into account 16-bit colors?

That is better done using 'if {[tk windowingsystem] eq "win32"}
{...}'. The windowingsystem command is preferred over platform because
they are not always equivalent (for instance, MacOSX may use either
x11 or aqua).
To test the colour-depth there is [winfo depth .] which returns 16
when using the 16bit color on XP and 32 on Win7 with full color.

Pat Thoyts
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[prev in list] [next in list] [prev in thread] [next in thread]