[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH 3/3] transport: don't show push status if --quiet is given
From:       Sebastian Pipping <webmaster () hartwork ! org>
Date:       2009-08-31 19:39:06
Message-ID: 4A9C26DA.9010701 () hartwork ! org
[Download RAW message or body]

Jeff King wrote:
> Junio applied the series, and it is in 'master' right now (and so should
> be part of the upcoming 1.6.5).
> 
> Using "git push -q" will do what you want,

That's great news.  Thanks for the quick reply.


> but playing with it a bit, I
> think there is one bit missing from the original series:
> 
> -- >8 --
> Subject: [PATCH] push: teach --quiet to suppress "Everything up-to-date"
> 
> This should have been part of 481c7a6, whose goal was to
> make "git push -q" silent unless there is an error.
> 
> Signed-off-by: Jeff King <peff@peff.net>
> ---
>  transport.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/transport.c b/transport.c
> index ce91387..f2bd998 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -908,7 +908,7 @@ int transport_push(struct transport *transport,
>  				update_tracking_ref(transport->remote, ref, verbose);
>  		}
>  
> -		if (!ret && !refs_pushed(remote_refs))
> +		if (!quiet && !ret && !refs_pushed(remote_refs))
>  			fprintf(stderr, "Everything up-to-date\n");
>  		return ret;
>  	}

Would be great to have that patch in too.



Sebastian
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]