[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH] git-add -p: be able to undo a given hunk
From:       Nanako Shiraishi <nanako3 () lavabit ! com>
Date:       2009-07-24 10:32:07
Message-ID: 20090724193207.6117 () nanako3 ! lavabit ! com
[Download RAW message or body]

Quoting Junio C Hamano <gitster@pobox.com>

> I fear tempting a new user who sees "undo" to say "yeah, I added the
> change in this hunk to the index by mistake, please undo", which would
> lose the work.  The confusion is easier to avoid if "add" only manipulates
> the index without harming the work tree, and the user used a different
> command, namely "checkout from the index", to get rid of the remaining
> debug cruft, once s/he added all the necessary bits to the index perhaps
> after a multi-stage commit session.

I can see your argument that this might introduce more danger for newbies. As you \
said yourself number of times, nobody will stay being a newbie forever, and I don't \
think it is wise to reject a feature that is very handy for experts based solely on \
such a fear.

-- 
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[prev in list] [next in list] [prev in thread] [next in thread]