[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [RFC PATCH] Make the rebase edit mode really end up in an edit
From:       "Anders Melchiorsen" <mail () cup ! kalibalik ! dk>
Date:       2009-01-16 10:27:46
Message-ID: 49548.bFoQE3daRhY=.1232101666.squirrel () webmail ! hotelhot ! dk
[Download RAW message or body]

Johan Herland wrote:

> 	edit e8902c1 Foo
>
> we should consider something like
>
> 	pick e8902c1 Foo
> 	halt

Of all the suggestions, I like this one the most. Also, when placed like
this, I am suddenly no longer opposed to the word "halt".


> 	amend e8902c1 Foo
>
> does a "pick" followed by "commit --amend" (for editing the commit
> message), followed by "rebase --continue".

I do not think that "amend" is the best word for editing only the commit
message. A "commit --amend" can also make a new tree, so reusing the word
with a different meaning could be bad.

As for alternatives, however, I can only come up with "copyedit", and that
is so horrible that I will not even propose it :-)


Cheers,
Anders.


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]