[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [EGIT PATCH] Add an import wizard for Eclipse projects as part
From:       "Shawn O. Pearce" <spearce () spearce ! org>
Date:       2008-12-31 15:54:44
Message-ID: 20081231155444.GH29071 () spearce ! org
[Download RAW message or body]

Robin Rosenberg <robin.rosenberg@dewire.com> wrote:
> This adds an optional page for importing Eclipse style projects
> as part of the clone operation.
> 
> This patch I think, greatly simplifies getting an Eclipse based project
> into the workbench.

Yes, yes it does!
 
> I'm mostly interested in comments on pure bugs. E.g. know it's
> blocking when the user selects to import the projects as part of the
> clone process, I also know I'm reusing internal messages and not supplying
> NLS style constansts for all textx.

I noticed you mispelled "showImportWizard" as "showImportWizarad",
but otherwise it looks reasonable to me.  I'd like to see the NLS
stuff extracted out before we apply the patch though.

The blocking part is annoying, but there isn't really a better
way to do it.  What would be worse is going into the background,
then popping open a modal dialog when it completes, as it would
really disrupts the user.  So just don't clone massive projects
and expect to use your workbench at the same time.  :-)

-- 
Shawn.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]