[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH 1/7] Windows: Add workaround for MSYS' path conversion
From:       Steffen Prohaska <prohaska () zib ! de>
Date:       2008-09-21 7:48:27
Message-ID: C76DB1B2-D9AB-4BA1-A983-E39D156F56A6 () zib ! de
[Download RAW message or body]


On Aug 17, 2008, at 10:35 PM, Johannes Sixt wrote:

> On Sonntag, 17. August 2008, Steffen Prohaska wrote:
>> MSYS' automatic path conversion causes problems when passing paths  
>> as '-D'
>> arguments to the compiler.  MSYS tries to be smart and converts  
>> absolute
>> paths to native Windows paths.  But we want the paths as we compute  
>> them in
>> the Makefile.
>
> Huh? Doesn't the Makefile compute paths like "/c/path/to/git"? We  
> certainly
> don't want to compile such paths into git that in Windows speak  
> actually
> mean "c:/path/to/git" - git is not an MSYS program and wouldn't  
> understand
> the former. Which form of conversion are you refering to?


MSYS' automatic path conversion causes problems when passing paths as
defines ('-D' arguments to the compiler).  MSYS tries to be smart and
converts absolute paths to native Windows paths, e.g. if MSYS sees
"/bin" it converts it to "c:/msysgit/bin".  But we want completely
unmodified paths; e.g. if we set bindir in the Makefile to "/bin", the
define BINDIR shall expand to "/bin".  Conversion to absolute Windows
path will takes place later, during runtime.

I'll update the commit message.

	Steffen


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]