[prev in list] [next in list] [prev in thread] [next in thread]
List: git
Subject: Re: [PATCH 6/7] Modify setup_path() to only add git_exec_path() to PATH
From: Johannes Sixt <johannes.sixt () telecom ! at>
Date: 2008-08-17 20:28:14
Message-ID: 200808172228.14424.johannes.sixt () telecom ! at
[Download RAW message or body]
On Sonntag, 17. August 2008, Steffen Prohaska wrote:
> Searching git programs only in the highest-priority location is
> sufficient. If the user explicitly overrides the default location
> (by --exec-path or GIT_EXEC_PATH), we can safely expect that the
> required programs are there.
...
> --- a/exec_cmd.c
> +++ b/exec_cmd.c
> @@ -114,9 +114,7 @@ void setup_path(void)
>
> strbuf_init(&new_path, 0);
>
> - add_path(&new_path, argv_exec_path);
> - add_path(&new_path, getenv(EXEC_PATH_ENVIRONMENT));
> - add_path(&new_path, system_path(GIT_EXEC_PATH));
> + add_path(&new_path, git_exec_path());
> add_path(&new_path, argv0_path);
>
> if (old_path)
I thought about a change like this, too. But I recall that this area has been
changed several times. One thread I found here:
http://thread.gmane.org/gmane.comp.version-control.git/62472
See also the commit message of 77cb17e940, which introduces exec_cmd.*.
But probably the points raised there are already moot, and your change is
good.
-- Hannes
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic