[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH] Documentation/git-gc.txt: change --aggressive description
From:       Pieter de Bie <pdebie () ai ! rug ! nl>
Date:       2008-05-14 6:48:19
Message-ID: FCA89971-FDBB-4E44-82CE-C0AA854A4667 () ai ! rug ! nl
[Download RAW message or body]


On 13 mei 2008, at 13:52, Johannes Schindelin wrote:
>> The documentation for the --aggressive flag was misleading, hinting  
>> that
>> running git gc with --aggressive is a good thing. However, -- 
>> aggressive
>> only really makes sense if you have a bad pack file, such as from
>> git-fast-import.
>
> I disagree.  It makes sense to "git gc --aggressive" also after  
> cloning
> from somebody who did not do so.

The problem with this is that your pack might increase in size, which  
you can't know in advance. Running "git gc --aggressive" on the git  
repo for example increases its size from 20MB to 30MB.

The current wording at least makes it sound as if --aggressive will  
always result in a smaller pack, which is simply not true. Increasing  
the window and depth might help, but 250 or even 100 can be too much  
on any decently size repository.

How about dropping the last sentence ("Using --aggressive only makes  
sense if you have a badly packed repository, such as created by git- 
fast-import.") then?

- Pieter

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]