[prev in list] [next in list] [prev in thread] [next in thread]
List: git
Subject: Re: [PATCHv4 4/4] user.warnautomatic: add config to control if the committer ident is shown
From: "=?ISO-8859-1?Q?Santi_B=E9jar?=" <sbejar () gmail ! com>
Date: 2008-05-07 16:32:24
Message-ID: 8aa486160805070932w44edf4b0j3b712ec22c10fe7d () mail ! gmail ! com
[Download RAW message or body]
On Wed, May 7, 2008 at 6:12 PM, Junio C Hamano <junio@pobox.com> wrote:
> Santi Béjar <sbejar@gmail.com> writes:
>
> > Signed-off-by: Santi Béjar <sbejar@gmail.com>
>
> By setting this new variable the user can squelch undesired noise the
> previous change introduces, but the user can just set user.name and
> user.email to desired values to squelch it anyway.
Or the user prefers the automatic ident.
>
> So either this new variable is superfluous, or the previous change is too
> susceptible to produce false positives that need squelching with such a
> variable, or both. In any case, not a very good sign.
For me it is superfluous, as I prefer to see what is the committer
ident when it is generated.
I even said I prefer just showing the automatic ident. I sent it in
case it was decided it was worth.
Santi
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic