[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH] Functions for updating refs.
From:       Johannes Sixt <j.sixt () eudaptics ! com>
Date:       2007-09-04 15:08:54
Message-ID: 46DD7506.3090503 () eudaptics ! com
[Download RAW message or body]

Johannes Schindelin schrieb:
> Hi,
> 
> On Tue, 4 Sep 2007, Johannes Sixt wrote:
> 
>> Johannes Schindelin schrieb:
>>> On Tue, 4 Sep 2007, Carlos Rica wrote:
>>>> +int update_ref_or_die(const char *action, const char *refname,
>>>> +				const unsigned char *sha1,
>>>> +				const unsigned char *oldval, int flags)
>>> Should this not be "void"?  And should it not use update_ref_or_error()?
>> It should not use *_error() directly because then it would print two error
>> messages in a row.
> 
> Well, my idea was to let _error() print the message, and just die().

How do you avoid that die() prints an error, too?

-- Hannes
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]