[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gimp-developer
Subject:    Re: [gimp-devel] gimpprotocol.c ? (again)
From:       Ray Lehtiniemi <rayl () netrover ! com>
Date:       1998-08-23 0:10:05
[Download RAW message or body]

On Sat, 22 Aug 1998, Asbjoern Pettersen wrote:

> Any GIMPers out there who could tell ?
> 
> WHY isn't the items use_xshm ans color_cube[3]  set ?
> They shouldn't be undefined !

this does seem to be the case....  it looks like as things stand, plugins
will never use X shared memory and will have 0 shades of gray for their
previews.

here's a patch against 1.0, bumping the protocol version as well.  maybe
someone who knows more about libgimp (i'm largely ignorant) can have a look
and verify this?


Index: gimpprotocol.c
===================================================================
RCS file: /debian/home/gnomecvs/gimp/libgimp/gimpprotocol.c,v
retrieving revision 1.4
diff -u -r1.4 gimpprotocol.c
--- gimpprotocol.c	1998/04/13 05:41:05	1.4
+++ gimpprotocol.c	1998/08/22 23:57:36
@@ -338,8 +338,10 @@
     return;
   if (!wire_read_int8 (fd, (guint8*) &config->install_cmap, 1))
     return;
-  if (!wire_read_int8 (fd, (guint8*) config->color_cube, 3))
+  if (!wire_read_int8 (fd, (guint8*) &config->use_xshm, 1))
     return;
+  if (!wire_read_int8 (fd, (guint8*) config->color_cube, 4))
+    return;
 
   msg->data = config;
 }
@@ -361,8 +363,10 @@
   if (!wire_write_double (fd, &config->gamma, 1))
     return;
   if (!wire_write_int8 (fd, (guint8*) &config->install_cmap, 1))
+    return;
+  if (!wire_write_int8 (fd, (guint8*) &config->use_xshm, 1))
     return;
-  if (!wire_write_int8 (fd, (guint8*) config->color_cube, 3))
+  if (!wire_write_int8 (fd, (guint8*) config->color_cube, 4))
     return;
 }
 
Index: gimpprotocol.h
===================================================================
RCS file: /debian/home/gnomecvs/gimp/libgimp/gimpprotocol.h,v
retrieving revision 1.3
diff -u -r1.3 gimpprotocol.h
--- gimpprotocol.h	1998/04/13 05:41:06	1.3
+++ gimpprotocol.h	1998/08/22 23:57:36
@@ -25,7 +25,7 @@
 
 /* Increment every time the protocol changes
  */
-#define GP_VERSION 0x0002
+#define GP_VERSION 0x0003
 
 
 enum {

-----------------------------------------------------------------------------
  Ray Lehtiniemi (rayl@netrover.com)

[prev in list] [next in list] [prev in thread] [next in thread]