[prev in list] [next in list] [prev in thread] [next in thread]
List: geos-devel
Subject: Re: [geos-devel] Checking GEOS master (state 8 October)
From: Martin Davis <mtnclimb () gmail ! com>
Date: 2020-10-13 19:06:27
Message-ID: CAK2ens2DigVqJj3jn1wKbKajA-wOTqJuAv_H730LhL3wUOVNXg () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
That output is coming from HeuristicOverlay.cpp:
https://github.com/libgeos/geos/blame/c4aebbbc048618e75b39f6c8d85dce8e8216cf9f/src/geom/HeuristicOverlay.cpp#L206
It shouldn't be showing up unless GEOS_DEBUG_HEURISTICOVERLAY has been
enabled, however.
On Tue, Oct 13, 2020 at 11:40 AM Roger Bivand <Roger.Bivand@nhh.no> wrote:
> On Tue, 13 Oct 2020, Paul Ramsey wrote:
>
> > In Cmake set DISABLE_OVERLAYNG to OFF
>
> Thanks, never Cmake here, am trying ../configure --enable-overlayng. I'm
> still puzzled about the free output to console not going through the error
> or warning handler.
>
> Roger
>
>
> > P
> >
> > > On Oct 13, 2020, at 11:23 AM, Roger Bivand <Roger.Bivand@nhh.no> wrote:
> > >
> > > On Tue, 13 Oct 2020, Paul Ramsey wrote:
> > >
> > > >
> > > >
> > > > > On Oct 13, 2020, at 11:08 AM, Roger Bivand <Roger.Bivand@nhh.no>
> wrote:
> > > > >
> > > > > I've been checking the possible fallout from Overlay_NG (assuming
> that building from master on 8 October uses the new code) in some R
> packages, in particular sf and rgeos. I see messages such as:
> > > > >
> > > > > CBR: result (after common-bits addition) is INVALID:
> Self-intersection at or near point 368576.69999999995 864696
> (368576.69999999995343 864696)
> > > >
> > > > That looks like the old overlay handler. Have you turned NG on in your
> build?
> > >
> > > Thanks for the quick response. First, is "master" the correct branch
> (gitea)? If yes, what is the incantation - I couldn't find any reference to
> NG in the code or configure.ac? I'd assumed from earlier discussion here
> that NG was on by default on "master".
> > >
> > > Roger
> > >
> > > >
> > > > P
> > > >
> > > >
> > > > >
> > > > > followed by the text representation of the object dumped to console.
> The message and the dumped object are not passed through error or warning
> handlers passed in through initGEOS_r(), and so are hard to trap and
> handle. Is this a temporary feature which will be normalised for 3.9.0?
> > > > >
> > > > > So far I don't think that there are obvious failures in R packages
> related to the new code (again assuming that a straight build of master of
> 8 November exercises Overlay_NG), but the unexpected output was surprising.
> > > > >
> > > > > Best wishes,
> > > > >
> > > > > Roger
> > > > >
> > > > > --
> > > > > Roger Bivand
> > > > > Department of Economics, Norwegian School of Economics,
> > > > > Helleveien 30, N-5045 Bergen, Norway.
> > > > > voice: +47 55 95 93 55; e-mail: Roger.Bivand@nhh.no
> > > > > https://orcid.org/0000-0003-2392-6140
> > > > > https://scholar.google.no/citations?user=AWeghB0AAAAJ&hl=en
> > > > > _______________________________________________
> > > > > geos-devel mailing list
> > > > > geos-devel@lists.osgeo.org
> > > > > https://lists.osgeo.org/mailman/listinfo/geos-devel
> > > >
> > > >
> > >
> > > --
> > > Roger Bivand
> > > Department of Economics, Norwegian School of Economics,
> > > Helleveien 30, N-5045 Bergen, Norway.
> > > voice: +47 55 95 93 55; e-mail: Roger.Bivand@nhh.no
> > > https://orcid.org/0000-0003-2392-6140
> > > https://scholar.google.no/citations?user=AWeghB0AAAAJ&hl=en
> >
> >
>
> --
> Roger Bivand
> Department of Economics, Norwegian School of Economics,
> Helleveien 30, N-5045 Bergen, Norway.
> voice: +47 55 95 93 55; e-mail: Roger.Bivand@nhh.no
> https://orcid.org/0000-0003-2392-6140
> https://scholar.google.no/citations?user=AWeghB0AAAAJ&hl=en
> _______________________________________________
> geos-devel mailing list
> geos-devel@lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/geos-devel
[Attachment #5 (text/html)]
<div dir="ltr">That output is coming from HeuristicOverlay.cpp: <a \
href="https://github.com/libgeos/geos/blame/c4aebbbc048618e75b39f6c8d85dce8e8216cf9f/s \
rc/geom/HeuristicOverlay.cpp#L206">https://github.com/libgeos/geos/blame/c4aebbbc04861 \
8e75b39f6c8d85dce8e8216cf9f/src/geom/HeuristicOverlay.cpp#L206</a><div><br></div><div>It \
shouldn't be showing up unless GEOS_DEBUG_HEURISTICOVERLAY has been enabled, \
however.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On \
Tue, Oct 13, 2020 at 11:40 AM Roger Bivand <<a \
href="mailto:Roger.Bivand@nhh.no">Roger.Bivand@nhh.no</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, 13 Oct 2020, \
Paul Ramsey wrote:<br> <br>
> In Cmake set DISABLE_OVERLAYNG to OFF<br>
<br>
Thanks, never Cmake here, am trying ../configure --enable-overlayng. I'm <br>
still puzzled about the free output to console not going through the error <br>
or warning handler.<br>
<br>
Roger<br>
<br>
<br>
> P<br>
><br>
>> On Oct 13, 2020, at 11:23 AM, Roger Bivand <<a \
href="mailto:Roger.Bivand@nhh.no" target="_blank">Roger.Bivand@nhh.no</a>> \
wrote:<br> >><br>
>> On Tue, 13 Oct 2020, Paul Ramsey wrote:<br>
>><br>
>>><br>
>>><br>
>>>> On Oct 13, 2020, at 11:08 AM, Roger Bivand <<a \
href="mailto:Roger.Bivand@nhh.no" target="_blank">Roger.Bivand@nhh.no</a>> \
wrote:<br> >>>><br>
>>>> I've been checking the possible fallout from Overlay_NG \
(assuming that building from master on 8 October uses the new code) in some R \
packages, in particular sf and rgeos. I see messages such as:<br> \
>>>><br> >>>> CBR: result (after common-bits addition) is \
INVALID: Self-intersection at or near point 368576.69999999995 864696 \
(368576.69999999995343 864696)<br> >>><br>
>>> That looks like the old overlay handler. Have you turned NG on in your \
build?<br> >><br>
>> Thanks for the quick response. First, is "master" the correct \
branch (gitea)? If yes, what is the incantation - I couldn't find any reference \
to NG in the code or <a href="http://configure.ac" rel="noreferrer" \
target="_blank">configure.ac</a>? I'd assumed from earlier discussion here that \
NG was on by default on "master".<br> >><br>
>> Roger<br>
>><br>
>>><br>
>>> P<br>
>>><br>
>>><br>
>>>><br>
>>>> followed by the text representation of the object dumped to console. \
The message and the dumped object are not passed through error or warning handlers \
passed in through initGEOS_r(), and so are hard to trap and handle. Is this a \
temporary feature which will be normalised for 3.9.0?<br> >>>><br>
>>>> So far I don't think that there are obvious failures in R \
packages related to the new code (again assuming that a straight build of master of 8 \
November exercises Overlay_NG), but the unexpected output was surprising.<br> \
>>>><br> >>>> Best wishes,<br>
>>>><br>
>>>> Roger<br>
>>>><br>
>>>> --<br>
>>>> Roger Bivand<br>
>>>> Department of Economics, Norwegian School of Economics,<br>
>>>> Helleveien 30, N-5045 Bergen, Norway.<br>
>>>> voice: +47 55 95 93 55; e-mail: <a href="mailto:Roger.Bivand@nhh.no" \
target="_blank">Roger.Bivand@nhh.no</a><br> >>>> <a \
href="https://orcid.org/0000-0003-2392-6140" rel="noreferrer" \
target="_blank">https://orcid.org/0000-0003-2392-6140</a><br> >>>> <a \
href="https://scholar.google.no/citations?user=AWeghB0AAAAJ&hl=en" \
rel="noreferrer" target="_blank">https://scholar.google.no/citations?user=AWeghB0AAAAJ&hl=en</a><br>
>>>> _______________________________________________<br>
>>>> geos-devel mailing list<br>
>>>> <a href="mailto:geos-devel@lists.osgeo.org" \
target="_blank">geos-devel@lists.osgeo.org</a><br> >>>> <a \
href="https://lists.osgeo.org/mailman/listinfo/geos-devel" rel="noreferrer" \
target="_blank">https://lists.osgeo.org/mailman/listinfo/geos-devel</a><br> \
>>><br> >>><br>
>><br>
>> --<br>
>> Roger Bivand<br>
>> Department of Economics, Norwegian School of Economics,<br>
>> Helleveien 30, N-5045 Bergen, Norway.<br>
>> voice: +47 55 95 93 55; e-mail: <a href="mailto:Roger.Bivand@nhh.no" \
target="_blank">Roger.Bivand@nhh.no</a><br> >> <a \
href="https://orcid.org/0000-0003-2392-6140" rel="noreferrer" \
target="_blank">https://orcid.org/0000-0003-2392-6140</a><br> >> <a \
href="https://scholar.google.no/citations?user=AWeghB0AAAAJ&hl=en" \
rel="noreferrer" target="_blank">https://scholar.google.no/citations?user=AWeghB0AAAAJ&hl=en</a><br>
><br>
><br>
<br>
-- <br>
Roger Bivand<br>
Department of Economics, Norwegian School of Economics,<br>
Helleveien 30, N-5045 Bergen, Norway.<br>
voice: +47 55 95 93 55; e-mail: <a href="mailto:Roger.Bivand@nhh.no" \
target="_blank">Roger.Bivand@nhh.no</a><br> <a \
href="https://orcid.org/0000-0003-2392-6140" rel="noreferrer" \
target="_blank">https://orcid.org/0000-0003-2392-6140</a><br> <a \
href="https://scholar.google.no/citations?user=AWeghB0AAAAJ&hl=en" \
rel="noreferrer" target="_blank">https://scholar.google.no/citations?user=AWeghB0AAAAJ&hl=en</a><br>
_______________________________________________<br>
geos-devel mailing list<br>
<a href="mailto:geos-devel@lists.osgeo.org" \
target="_blank">geos-devel@lists.osgeo.org</a><br> <a \
href="https://lists.osgeo.org/mailman/listinfo/geos-devel" rel="noreferrer" \
target="_blank">https://lists.osgeo.org/mailman/listinfo/geos-devel</a></blockquote></div>
[Attachment #6 (text/plain)]
_______________________________________________
geos-devel mailing list
geos-devel@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/geos-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic