--===============6327044581239178856== Content-Type: multipart/alternative; boundary=047d7b3a91e60dfdf504db5be65f --047d7b3a91e60dfdf504db5be65f Content-Type: text/plain; charset=ISO-8859-1 Hey! I have submitted my GSoC Proposal for the project "Adding Voronoi Diagrams to GEOS" here: http://www.google-melange.com/gsoc/proposal/review/google/gsoc2013/vishal_tiwari/13001 kindly review it and give me feedback so that i can further improve it before the application deadline. Thanks, Vishal Tiwari On 10 April 2013 15:38, Sandro Santilli wrote: > On Wed, Apr 10, 2013 at 02:17:44PM +0530, vishal tiwari wrote: > > Hey, > > I suppose only those test cases needs to be ported that correspond to > > Voronoi class. But i see many other test cases for other class that are > > missing. So just asking for clarification, do we need to ported other > test > > cases as well? > > For the purpose of Voronoi you only need to port tests for the Voronoi > class and any class used by the Voronoi class. But if you find yourself > having more time porting more tests would be very useful > > > And as for the C-API this is what i have understood: it provides a > wrapper > > to the C++ functions. All the reference functions are implemented in > > geos_ts_c.cpp. And all the functions that are exposed to the users are in > > geos_c.cpp and its header file, geos_c.h. > > More or less. Actually geos_ts.cpp contains the _Thread_Safe_ (supposedly) > version of the functions. It's been added later so the old API (officially > non thread-safe) is retained. In theory, new functions could STOP exposing > a non-thread-safe version of the signature but I haven't started this to > avoid having a mix of new and old APIs around. So at the moment it's > recommended to always keep both APIs. > > Both TS and non-TS function are found in geos_c.h. The non-TS function are > all simple wrappers to the TS ones. > > > Regarding the Gsoc proposal in the 'Describe your idea' section of the > > OSGeo proposal Application, this is what i have thought about from our > > discussion on the project: > > > > > https://docs.google.com/document/d/1biGlOqTnS7SnlxPOcFKrxj7_QEMYd1VtAFDms6L3AnY/edit > > Sounds good to me. Maybe Anne has some suggestions for the > gsoc-specific needs. > > --strk; > > > > > > > Looking for your feedback on how it can further be improved. > > > > > > Thanks and kind regards, > > > > Vishal > > > > > > > > * > > > > > > On 4 April 2013 19:46, Sandro Santilli wrote: > > > > > On Thu, Apr 04, 2013 at 05:02:56PM +0530, vishal tiwari wrote: > > > > Hey, > > > > Here is the structure of classes that is required by the * > > > > VoronoiDiagramBuilder* class: (The ones in *bold* needs to be ported) > > > > > > > > 1. Geometry > > > > 2. Geometry Factor > > > > 3. QuadEdgeSubdivision: > > > > - Methods required for *VoronoiDigramBuilder*: > > > > - *getVoronoiDiagram* > > > > - *getVoronoiCellPolugons* > > > > - *getVoronoiCellPolugon* > > > > - visitTriangle > > > > - *getVertexUniqueEdges* > > > > - TriangleCoordinateVisitor > > > > - *TriangleCircumcenterVisitor* > > > > - *TriangleEdgeListVisitor* > > > > - *TriangleVertexListVisitor* > > > > - *isFrameVertex* > > > > 4. TriangleVisitor(Interface) > > > > > > > > Plz let me know if i am missing some method or class which is > required > > > > for VoronoiDiagramBuilder port. > > > > > > Again, looking is part of the work. > > > You'll find out as you start porting if anything is missing. > > > > > > > Is it me or its very few work for a Gsoc Project? > > > > > > Don't forget the testcases for the C++ implementation, > > > the C-API exposure and relative testcases and audit for > > > memory leakage. > > > > > > After you've done, if you still have time it'd be nice to > > > work on improving the performance of it :) > > > > > > --strk; > > > > > > > > > > > -- > > Vishal Tiwari > > Undergraduate > > Computer Science and Engineering > > Lab for Spatial Informatics > > IIIT-Hyderabad > _______________________________________________ > geos-devel mailing list > geos-devel@lists.osgeo.org > http://lists.osgeo.org/mailman/listinfo/geos-devel > -- Vishal Tiwari Undergraduate Computer Science and Engineering Lab for Spatial Informatics IIIT-Hyderabad --047d7b3a91e60dfdf504db5be65f Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hey!
I have submitted my GSoC Proposal for the project= "Adding Voronoi Diag= rams to GEOS" here:
http://www.google-melange.co= m/gsoc/proposal/review/google/gsoc2013/vishal_tiwari/13001

kindly review it and give me feedbac= k so that i can=A0further=A0improve it before the application deadline.
Thanks,
Vishal Tiwari

On 10 April 2013 15:38, Sandro Santilli <strk= @keybit.net> wrote:
On Wed, Apr 10, 2013 at 02:17:44PM +053= 0, vishal tiwari wrote:
> Hey,
> I suppose only those test cases needs to be ported that correspond to<= br> > Voronoi class. But i see many other test cases for other class that ar= e
> missing. So just asking for clarification, do we need to ported other = test
> cases as well?

For the purpose of Voronoi you only need to port tests for the Vorono= i
class and any class used by the Voronoi class. But if you find yourself
having more time porting more tests would be very useful

> And as for the C-API this is what i have understood: it provides a wra= pper
> to the C++ functions. All the reference functions are implemented in > geos_ts_c.cpp. And all the functions that are exposed to the users are= in
> geos_c.cpp and its header file, geos_c.h.

More or less. Actually geos_ts.cpp contains the _Thread_Safe_ (suppos= edly)
version of the functions. It's been added later so the old API (officia= lly
non thread-safe) is retained. In theory, new functions could STOP exposing<= br> a non-thread-safe version of the signature but I haven't started this t= o
avoid having a mix of new and old APIs around. So at the moment it's recommended to always keep both APIs.

Both TS and non-TS function are found in geos_c.h. The non-TS function are<= br> all simple wrappers to the TS ones.

> Regarding the Gsoc proposal in the 'Describe your idea' sectio= n of the
> OSGeo proposal Application, this is what i have thought about from our=
> discussion on the project:
>
> https://docs.google.com/docume= nt/d/1biGlOqTnS7SnlxPOcFKrxj7_QEMYd1VtAFDms6L3AnY/edit

Sounds good to me. Maybe Anne has some suggestions for the
gsoc-specific needs.

--strk;

>
>
> Looking for your feedback on how it can further be improved.
>
>
> Thanks and kind regards,
>
> Vishal
>
>
>
> *
>
>
> On 4 April 2013 19:46, Sandro Santilli <strk@keybit.net> wrote:
>
> > On Thu, Apr 04, 2013 at 05:02:56PM +0530, vishal tiwari wrote: > > > Hey,
> > > Here is the structure of classes that is required by the * > > > VoronoiDiagramBuilder* class: (The ones in *bold* needs to b= e ported)
> > >
> > > =A0 =A01. Geometry
> > > =A0 =A02. Geometry Factor
> > > =A0 =A03. QuadEdgeSubdivision:
> > > =A0 =A0 =A0 - Methods required for *VoronoiDigramBuilder*: > > > =A0 =A0 =A0 =A0 =A0- *getVoronoiDiagram*
> > > =A0 =A0 =A0 =A0 =A0- *getVoronoiCellPolugons*
> > > =A0 =A0 =A0 =A0 =A0- *getVoronoiCellPolugon*
> > > =A0 =A0 =A0 =A0 =A0- visitTriangle
> > > =A0 =A0 =A0 =A0 =A0- *getVertexUniqueEdges*
> > > =A0 =A0 =A0 =A0 =A0- TriangleCoordinateVisitor
> > > =A0 =A0 =A0 =A0 =A0- *TriangleCircumcenterVisitor*
> > > =A0 =A0 =A0 =A0 =A0- *TriangleEdgeListVisitor*
> > > =A0 =A0 =A0 =A0 =A0- *TriangleVertexListVisitor*
> > > =A0 =A0 =A0 =A0 =A0- *isFrameVertex*
> > > =A0 =A0 =A0 4. TriangleVisitor(Interface)
> > >
> > > Plz let me know if i am missing some method or class which i= s required
> > > for VoronoiDiagramBuilder port.
> >
> > Again, looking is part of the work.
> > You'll find out as you start porting if anything is missing.<= br> > >
> > > Is it me or its very few work for a Gsoc Project?
> >
> > Don't forget the testcases for the C++ implementation,
> > the C-API exposure and relative testcases and audit for
> > memory leakage.
> >
> > After you've done, if you still have time it'd be nice to=
> > work on improving the performance of it :)
> >
> > --strk;
> >
>
>
>
> --
> Vishal Tiwari
> Undergraduate
> Computer Science and Engineering
> Lab for Spatial Informatics
> IIIT-Hyderabad
_______________________________________________
geos-devel mailing list
geos-devel@= lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/geos-devel



--
=
Vishal Tiwari
Undergraduate
Computer Science= and=A0Engineering
Lab for Spatial Informatics
IIIT-Hyd= erabad
--047d7b3a91e60dfdf504db5be65f-- --===============6327044581239178856== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ geos-devel mailing list geos-devel@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/geos-devel --===============6327044581239178856==--