[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-portage-dev
Subject:    [gentoo-portage-dev] Re: [PATCH] _post_phase_userpriv_perms: handle $HOME (bug 713100)
From:       Zac Medico <zmedico () gentoo ! org>
Date:       2020-03-22 20:06:16
Message-ID: 5423abe3-75cc-bba7-8911-fad46a9f8087 () gentoo ! org
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


Please ignor this accidental re-send, it is identical to this previous send:

https://archives.gentoo.org/gentoo-portage-dev/message/a6cb4527a2aa29c3aafccc17d91b44e5

On 3/22/20 12:56 PM, Zac Medico wrote:
> Ensure that the userpriv UID has appropriate permission for files
> created in $HOME during privileged phases like pkg_setup, in the
> same way as for $T. This prevents potential permission issues for
> programs invoked during unprivileged phases, and it improves
> alignment with PMS which specifies identical behavior for both
> $HOME and $T.
> 
> Bug: https://bugs.gentoo.org/713100
> Signed-off-by: Zac Medico <zmedico@gentoo.org>
> ---
>  lib/portage/package/ebuild/doebuild.py | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/portage/package/ebuild/doebuild.py b/lib/portage/package/ebuild/doebuild.py
> index 75fcb8a51..2bff94cb1 100644
> --- a/lib/portage/package/ebuild/doebuild.py
> +++ b/lib/portage/package/ebuild/doebuild.py
> @@ -1765,9 +1765,10 @@ def _post_phase_userpriv_perms(mysettings):
>  	if "userpriv" in mysettings.features and secpass >= 2:
>  		""" Privileged phases may have left files that need to be made
>  		writable to a less privileged user."""
> -		apply_recursive_permissions(mysettings["T"],
> -			uid=portage_uid, gid=portage_gid, dirmode=0o700, dirmask=0,
> -			filemode=0o600, filemask=0)
> +		for path in (mysettings["HOME"], mysettings["T"]):
> +			apply_recursive_permissions(path,
> +				uid=portage_uid, gid=portage_gid, dirmode=0o700, dirmask=0,
> +				filemode=0o600, filemask=0)
>  
>  
>  def _check_build_log(mysettings, out=None):
> 


-- 
Thanks,
Zac


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]