[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-portage-dev
Subject:    [gentoo-portage-dev] [PATCH] sync.py: add warning when sync-type is not set
From:       Alexandru Elisei <alexandru.elisei () gmail ! com>
Date:       2017-01-31 19:33:20
Message-ID: CAB-4s4nE=t7ackTmzmHG28=KnqCGkk6WcirJs2=YVcvN4OQ00w () mail ! gmail ! com
[Download RAW message or body]

---
 pym/portage/emaint/modules/sync/sync.py | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/pym/portage/emaint/modules/sync/sync.py
b/pym/portage/emaint/modules/sync/sync.py
index 076297a..b4d65e7 100644
--- a/pym/portage/emaint/modules/sync/sync.py
+++ b/pym/portage/emaint/modules/sync/sync.py
@@ -205,9 +205,15 @@ class SyncRepos(object):
 					k = "--" + k.replace("_", "-")
 					self.emerge_config.opts[k] = v

-		selected_repos = [repo for repo in selected_repos if repo.sync_type
is not None]
 		msgs = []
-		if not selected_repos:
+		valid_repos = []
+		for repo in selected_repos:
+			if repo.sync_type is None:
+				msgs.extend([warn(" * ") + "Missing sync-type for repo: " + \
+					repo.name +  ", skipping...\n"])
+			else:
+				valid_repos.append(repo)
+		if not valid_repos:
 			msgs.append("Emaint sync, nothing to sync... returning")
 			if return_messages:
 				msgs.extend(self.rmessage([('None', os.EX_OK)], 'sync'))
@@ -223,7 +229,7 @@ class SyncRepos(object):
 			if 'parallel-fetch' in self.emerge_config.
 			target_config.settings.features else 1)
 		sync_scheduler = SyncScheduler(emerge_config=self.emerge_config,
-			selected_repos=selected_repos, sync_manager=sync_manager,
+			selected_repos=valid_repos, sync_manager=sync_manager,
 			max_jobs=max_jobs,
 			event_loop=global_event_loop() if portage._internal_caller else
 				EventLoop(main=False))
-- 
2.10.2

[prev in list] [next in list] [prev in thread] [next in thread]