[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-portage-dev
Subject:    Re: [gentoo-portage-dev] [PATCH] emerge: fix error handling for clean_logs
From:       Mike Gilbert <floppym () gentoo ! org>
Date:       2017-01-26 4:20:37
Message-ID: CAJ0EP4321Vs+=FFm9CQN58Dnshq8TtJqb1ZLNn=Bcw2P5tNiaw () mail ! gmail ! com
[Download RAW message or body]

On Wed, Jan 25, 2017 at 10:42 PM, Zac Medico <zmedico@gentoo.org> wrote:
> On 01/25/2017 07:16 PM, Mike Gilbert wrote:
>> Commit f143e58dd changed the return value of CleanLogs.clean() to a
>> tuple (returncode, messages).
>>
>> X-Gentoo-Bug: 607236
>> X-Gentoo-Bug-URL: https://bugs.gentoo.org/607236
>> ---
>>  pym/_emerge/post_emerge.py | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/pym/_emerge/post_emerge.py b/pym/_emerge/post_emerge.py
>> index 0cb533cf8..7e6063c52 100644
>> --- a/pym/_emerge/post_emerge.py
>> +++ b/pym/_emerge/post_emerge.py
>> @@ -29,10 +29,10 @@ def clean_logs(settings):
>>               return
>>
>>       cleanlogs = CleanLogs()
>> -     errors = cleanlogs.clean(settings=settings)
>> -     if errors:
>> +     returncode, msgs = cleanlogs.clean(settings=settings)
>> +     if not returncode:
>>               out = portage.output.EOutput()
>> -             for msg in errors:
>> +             for msg in msgs:
>>                       out.eerror(msg)
>>
>>  def display_news_notification(root_config, myopts):
>>
>
> I like Fixes: tags [1]. Otherwise, looks good.

Thanks. I adjusted the commit message and pushed this.

[prev in list] [next in list] [prev in thread] [next in thread]