[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-portage-dev
Subject:    Re: [gentoo-portage-dev] [PATCH] Colorize packages in user sets (bug 577720)
From:       Alexander Berntsen <bernalex () gentoo ! org>
Date:       2016-03-29 8:35:59
Message-ID: 56FA3E6F.1060305 () gentoo ! org
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 20/03/16 15:33, Adam Mills wrote:
> +			for set_name in root_config.sets:
> +				if set_name == "system":
> +					system = root_config.sets[set_name].findAtomForPackage(
> +						pkg, modified_use=self.conf.pkg_use_enabled(pkg))
> +				elif set_name == "selected":
> +					world = root_config.sets[set_name].findAtomForPackage(
> +						pkg, modified_use=self.conf.pkg_use_enabled(pkg))
> +				elif user_set is None and root_config.sets[set_name].isUserSet():
> +					user_set = root_config.sets[set_name].findAtomForPackage(
> +						pkg, modified_use=self.conf.pkg_use_enabled(pkg))
This is really silly. At the very least try to not repeat yourself so
much.

The patch otherwise looks OK, and the idea is OK by me. Unless someone
has any big objections, I can probably merge a cleaned up patch.
- -- 
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJW+j5tAAoJENQqWdRUGk8BKpYP/iG5tLtEv7Zf7AbPOj4Dkt1V
t25DMqUU0+uq3Wu0AsUsGYxg8K4dFMZ3+t54w4aykF5/lGNz/cz+O1NFy7WgQ/Y4
9pxkPIQ8py9FX8uh4Hm5/fplBJ5RP1CvvftLeImpKx/B2GTqtLDx0EYehfqRqWNa
2Hx6TE1GH3bbvQgJpl65L4c30JfIBP4pcW95EzUc4XFE87KV0abFFsPLc8sEewp8
NXDDvLZnC+8+BKlLuhyZArxfDp02kQWLd7ho3Uq1rB1LVTUCbxLkV8F9UHtCX9/w
XyyGkg/Xe4Ev1oLcMuEGWGcoQDdLA03CrTzZ59TYIrP2+/0EBCXfNPSy9SLehIew
N+RpgRqc6ecRVq4Nm5NbHfcYmieSKIJD9KPlLqFOShdLEn92gZp2syKkKd+R5JwE
voKVGMgAiJinZkNtwp/j4wgCoLf++I4FJ4BOWAkc7gkKOaDT7UnK2q3M9n6DTNtP
kbyB0cRMSbyMN75vLi2LdB37xC7a2aWCNUi0ssL183bocxhtcRUCxpUsA+dRnGWP
dKCoMzoYVcEARxbzukoJ1vuF+GN+tMoIHfAaXiAhTkwENn+s64b3pYy7tDRBjLxt
Wi3Fvh9h2ipU42wc0p8puZmT9v+60rcUKbNCjLQD9lEX9nh6bR91gB7FlPzU/ss8
Kqz55vBVouA/Fwkn+qZi
=TBB6
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]