[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-portage-dev
Subject:    Re: [gentoo-portage-dev] [PATCH] Support override of default profile EAPI (532670)
From:       Zac Medico <zmedico () gentoo ! org>
Date:       2014-12-22 19:54:36
Message-ID: 549876FC.3050407 () gentoo ! org
[Download RAW message or body]

On 12/22/2014 10:34 AM, Zac Medico wrote:
> On 12/22/2014 04:59 AM, Alexander Berntsen wrote:
>> The idea presented in the commit message header is very good. The
>> implementation discussed in the commit message body sounds a bit
>> messy, but I can't immediately think of another way to support this.
> 
> Given existing state of the code, I think my implementation is quite
> reasonable. It's seems a bit messy because the functions/methods
> involved need to deal with 3 different kinds of profile nodes:
> 
> 1) Regular profile nodes
> 
> 2) User profile override directory in /etc/portage/profile
> 
> 3) The root "profiles" directory, which is not really a profile node,
> but is used for repository-level configurations (package.mask being the
> most common example used by Gentoo)
> 
> I will add a note about this to the commit message, since it's not
> completely obvious unless you have had to dive into this code for some
> reason.

The updated commit message is here:

https://github.com/zmedico/portage/commit/582965f8e8f0071d50abe2e9510abe6659e10242

-- 
Thanks,
Zac

[prev in list] [next in list] [prev in thread] [next in thread]