[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-portage-dev
Subject:    Re: [gentoo-portage-dev] [PATCH] Add empty default src_prepare() as required by PMS
From:       Zac Medico <zmedico () gentoo ! org>
Date:       2014-09-22 18:01:21
Message-ID: 542063F1.7080702 () gentoo ! org
[Download RAW message or body]

On 09/22/2014 08:56 AM, Michał Górny wrote:
> Fixes: https://bugs.gentoo.org/show_bug.cgi?id=523182
> ---
>  bin/phase-functions.sh | 4 ++++
>  bin/phase-helpers.sh   | 4 ++++
>  2 files changed, 8 insertions(+)

Your changes appear to correctly fix the specific issue reported in bug
523182. However, I have a question about some of the other code in
commit 772ed29fd9e7cf722aed943adbe33a27f250e1ff:

	case "$eapi" in
		0|1) # EAPIs not supporting 'default'

			for x in pkg_nofetch src_unpack src_test ; do
				declare -F $x >/dev/null || \
					eval "$x() { __eapi0_$x; }"
			done

It appears as though pkg_nofetch is only defined for EAPIs 0 and 1.
Doesn't it also need to be defined for all of the other EAPIs? I can see
that src_unpack and src_test are defined later for the other EAPIs, but
pkg_nofetch is conspicuously absent.
-- 
Thanks,
Zac


[prev in list] [next in list] [prev in thread] [next in thread]