[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-portage-dev
Subject:    Re: [gentoo-portage-dev] [PATCH 2/2] TaskSequence.py: Fix starting an empty queue (bug 506186)
From:       Alexander Berntsen <bernalex () gentoo ! org>
Date:       2014-04-04 20:13:47
Message-ID: 533F127B.6020405 () gentoo ! org
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 04/04/14 21:36, Brian Dolbec wrote:
> --- pym/_emerge/TaskSequence.py | 5 +++-- 1 file changed, 3
> insertions(+), 2 deletions(-)
> 
> diff --git a/pym/_emerge/TaskSequence.py
> b/pym/_emerge/TaskSequence.py index 1fecf63..b4bfefe 100644 ---
> a/pym/_emerge/TaskSequence.py +++ b/pym/_emerge/TaskSequence.py @@
> -30,8 +30,9 @@ class TaskSequence(CompositeTask): 
> CompositeTask._cancel(self)
> 
> def _start_next_task(self): -
> self._start_task(self._task_queue.popleft(), -
> self._task_exit_handler) +		if self._task_queue: +
> self._start_task(self._task_queue.popleft(), +
> self._task_exit_handler)
> 
> def _task_exit_handler(self, task): if self._default_exit(task) !=
> os.EX_OK:
> 
I assume the check doesn't have to be atomic, so LGTM. Too long commit
msg though. Should be something like "TaskSequence: Don't start empty
queue (bug 506186)".

- -- 
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iF4EAREIAAYFAlM/EnsACgkQRtClrXBQc7WzCQD/W40mrQvUOlvnwXxZV3ZEOw5O
q02iC0nrH5shF8jpcwwA/0Yfgw5OLgyZYjrCpzWdxJZnZe2TbX0R8DtJIl9gCGTa
=fkZ3
-----END PGP SIGNATURE-----


[prev in list] [next in list] [prev in thread] [next in thread]