[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH 2/2] sys-apps/systemd-utils: add workaround for no-multilib
From:       Mike Gilbert <floppym () gentoo ! org>
Date:       2024-03-26 16:57:57
Message-ID: CAJ0EP40Ppj-freEO_WLyb1ceEbjaQQjOJ76y4NF+jqx4GKt-aQ () mail ! gmail ! com
[Download RAW message or body]

On Tue, Mar 26, 2024 at 12:51 PM Michał Górny <mgorny@gentoo.org> wrote:
>
> On Tue, 2024-03-26 at 11:01 -0400, Mike Gilbert wrote:
> > meson.build has some logic to build ia32 EFI binaries on x86_64 if the
> > toolchain is compatible. Rather than trying to reproduce this logic in
> > the ebuild, just try to build it and ignore any failures.
> >
> > If meson.build actually defines the targets but we have some other
> > compile error, this will move the failure to the install phase instead.
> >
>
> That's not a correct use of nonfatal.  It is supposed to be used to
> provide customized error handling (e.g. cleanup step before dying), not
> a cheap way to ignore errors.

I disagree; the error will not go unhandled, it's just being deferred
until later.

[prev in list] [next in list] [prev in thread] [next in thread]