[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH 1/2] */*: Replace dependency to virtual/linuxtv-dvb-headers by sys-kernel/li
From:       Matthias Schwarzott <zzam () gentoo ! org>
Date:       2024-02-25 20:55:21
Message-ID: 2e39fb03-ab3f-43ae-8895-97920bb49694 () gentoo ! org
[Download RAW message or body]

Am 25.02.24 um 18:54 schrieb Ionen Wolkens:
> On Tue, Feb 13, 2024 at 09:19:46AM +0100, Matthias Schwarzott wrote:
>> virtual/linuxtv-dvb-headers has been important in the past when
>> linux-headers was not yet up-to-date.
>> Now it just pulls in >=sys-kernel/linux-headers-3.7.
>> Even that could be dropped as it is part of @system.
>>
>> Bug: https://bugs.gentoo.org/924398
>> Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
> 
>> diff --git a/media-video/mpv/mpv-0.37.0-r1.ebuild b/media-video/mpv/mpv-0.37.0-r1.ebuild
>> index 731cc45c2106..9ce839af5283 100644
>> --- a/media-video/mpv/mpv-0.37.0-r1.ebuild
>> +++ b/media-video/mpv/mpv-0.37.0-r1.ebuild
>> @@ -116,7 +116,7 @@ RDEPEND="
>>   DEPEND="
>>   	${COMMON_DEPEND}
>>   	X? ( x11-base/xorg-proto )
>> -	dvb? ( virtual/linuxtv-dvb-headers )
>> +	dvb? ( >=sys-kernel/linux-headers-3.7 )
> 
> Had missed this mail (sorry), not that I have much to say about it.
> 
> I'd argue that there's no need to clutter ebuilds with the >=3.7 bit
> at this point, <3.7 is long gone (dropped 9 years ago, and its addition
> predates the tree's git migration).
> 
> Think should keep the dependency itself though, it's not part of
> @system on *all* profiles (virtual/os-headers has conditions esp.
> with some prefixes). Similar deal to depending on glibc when packages
> are prebuilt and cannot be used with musl so pkgcheck can warn if masks
> are missing.

I also wondered if I could drop the dependency completely.
Then decided for the simplest possible solution.

I will update it to only depend on linux-headers.

Regards
Matthias


[prev in list] [next in list] [prev in thread] [next in thread]