[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH 2/7] eclass/dotnet-pkg-utils.eclass: introduce new eclass
From:       Michał_Górny <mgorny () gentoo ! org>
Date:       2023-07-31 5:09:33
Message-ID: 7c0ad26dc92fa5a63f523df2347efb6bacef4900.camel () gentoo ! org
[Download RAW message or body]

On Sun, 2023-07-30 at 22:04 +0200, Maciej Barć wrote:
> W dniu 30.07.2023 o  21:34, Michał Górny pisze:
> > On Sun, 2023-07-30 at 16:26 +0200, Maciej Barć wrote:
> > > Bug: https://bugs.gentoo.org/900597
> > > Bug: https://github.com/gentoo/gentoo/pull/29309
> > > Signed-off-by: Maciej Barć <xgqt@gentoo.org>
> > > ---
> > >   eclass/dotnet-pkg-utils.eclass | 602 +++++++++++++++++++++++++++++++++
> > >   1 file changed, 602 insertions(+)
> > >   create mode 100644 eclass/dotnet-pkg-utils.eclass
> > > 
> > > diff --git a/eclass/dotnet-pkg-utils.eclass b/eclass/dotnet-pkg-utils.eclass
> > > new file mode 100644
> > > index 000000000..bdde11fe5
> > > --- /dev/null
> > > +++ b/eclass/dotnet-pkg-utils.eclass
> > > @@ -0,0 +1,602 @@
> > > +# Copyright 1999-2023 Gentoo Authors
> > > +# Distributed under the terms of the GNU General Public License v2
> > > +
> > > +# @ECLASS: dotnet-pkg-utils.eclass
> > > +# @MAINTAINER:
> > > +# Gentoo Dotnet project <dotnet@gentoo.org>
> > > +# @AUTHOR:
> > > +# Anna Figueiredo Gomes <navi@vlhl.dev>
> > > +# Maciej Barć <xgqt@gentoo.org>
> > > +# @SUPPORTED_EAPIS: 8
> > > +# @PROVIDES: nuget
> > > +# @BLURB: common functions and variables for builds using .NET SDK
> > > +# @DESCRIPTION:
> > > +# This eclass is designed to provide common definitions for .NET packages.
> > > +#
> > > +# This eclass does not export any phase functions, for that see
> > > +# the "dotnet-pkg" eclass.
> > 
> > Given how intrusive this is, I don't think "-utils" is a correct suffix.
> > It's for eclasses providing utility functions without affecting packages
> > implicitly.
> > 
> 
> What about "-common", like "elisp-common.eclass" has?
> 

Works for me.  It probably still doesn't really explain when you want "-
common", and when you want the main eclass.  I may have better
suggestions if I figured that out.


-- 
Best regards,
Michał Górny


[prev in list] [next in list] [prev in thread] [next in thread]