[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH] cmake.eclass: workaround S=${WORKDIR} creating builddir above ${WORKDIR}
From:       Sam James <sam () gentoo ! org>
Date:       2023-06-26 15:24:19
Message-ID: 87edly2qmf.fsf () gentoo ! org
[Download RAW message or body]


Ulrich Mueller <ulm@gentoo.org> writes:

>>>>>> On Mon, 26 Jun 2023, Sam James wrote:
>
>> +
>> +		# Avoid creating ${WORKDIR}_build (which is above WORKDIR).
>> +		# TODO: For EAPI > 8, we should ban S=WORKDIR for CMake.
>> +		# See bug #889420.
>> +		if [[ ${S} == ${WORKDIR} && ${BUILD_DIR} == ${WORKDIR}_build ]] ; then
>
> I'd suggest adding quotes to the RHS of the expression, to prevent
> globbing.

I'm fine with quoting the RHS, but I don't think it's worth making the
other changes given this works and it's already an edge case.

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]