[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH 1/3] autotools.eclass: Downgrade eqawarn for renaming configure.in
From:       Pacho Ramos <pacho () gentoo ! org>
Date:       2023-05-28 13:44:59
Message-ID: 83231c52342ace97f6ec40be4dea02e154f26ca3.camel () gentoo ! org
[Download RAW message or body]

[Attachment #2 (text/plain)]

El dom, 28-05-2023 a las 15:16 +0200, Ulrich Müller escribió:
> At this point, almost all upstreams will have switched to
> configure.ac.
> Therefore, configure.in is most likely an indication of an inactive
> upstream, and there is no useful way for the ebuild maintainer to
> silence the warning (other than the ebuild renaming the file).
> 
> Keep the message as einfo, so there is still an indication that the
> file
> was renamed.
> 
> Bug: https://bugs.gentoo.org/426262
> Signed-off-by: Ulrich Müller <ulm@gentoo.org>
> ---
>  eclass/autotools.eclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/eclass/autotools.eclass b/eclass/autotools.eclass
> index 91046b9f82f3..3a040b863eea 100644
> --- a/eclass/autotools.eclass
> +++ b/eclass/autotools.eclass
> @@ -400,7 +400,7 @@ eautoconf() {
>                 *)
>                                 # Move configure file to the new
> location only on newer EAPIs to ensure
>                                 # checks are done rather than
> retroactively breaking ebuilds.
> -                               eqawarn "Moving configure.in to
> configure.ac (bug #426262)"
> +                               einfo "Moving configure.in to
> configure.ac (bug #426262)"
>                                 mv configure.{in,ac} || die
>                         ;;
>                 esac

LGTM

Thanks!

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]