[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    [gentoo-dev] Re: [PATCH] profiles/base: add cache vars for -Wimplicit-function-declaration silencing
From:       Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen () gentoo ! org>
Date:       2023-02-28 18:43:06
Message-ID: 874jr53a1q.fsf () gentoo ! org
[Download RAW message or body]


Sam James <sam@gentoo.org> writes:

> Autoconf has a builtin check to try figure out how to make the compiler
> error out on implicit function declarations. This check necessarily emits
> such a warning/error. We know that -Werror=implicit-function-declaration
> will work on any compiler we care about, so just force that to avoid noise.
>
> This means we don't have to try whitelist 'strchr'.
>
> Signed-off-by: Sam James <sam@gentoo.org>
> ---
>  profiles/base/make.defaults | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/profiles/base/make.defaults b/profiles/base/make.defaults
> index ab69dbfae58ee..bdffd57047bbc 100644
> --- a/profiles/base/make.defaults
> +++ b/profiles/base/make.defaults
> @@ -181,3 +181,9 @@ ADA_TARGET="gnat_2021"
>  # Default targets for lua{,-single}.eclass
>  LUA_SINGLE_TARGET="lua5-1"
>  LUA_TARGETS="lua5-1"
> +
> +# Sam James <sam@gentoo.org> (2023-02-28)
> +# Reduce -Wimplicit-function-declaration noise from autoconf. Any compilers
> +# we care about should match these anyway. See https://wiki.gentoo.org/wiki/Modern_C_porting.
> +export ac_cv_c_undeclared_builtin_options="none needed"
> +export gl_cv_compiler_check_decl_option="-Werror=implicit-function-declaration"

LGTM.

-- 
Arsen Arsenović

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]