[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH] distutils-r1.eclass: fix typo in comment
From:       Michał_Górny <mgorny () gentoo ! org>
Date:       2022-09-26 10:06:58
Message-ID: 86cee4684c5d9a47b2823738754c3d562e2279a4.camel () gentoo ! org
[Download RAW message or body]

On Tue, 2022-09-20 at 17:17 +0200, Petr Vaněk wrote:
> Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
> ---
>  eclass/distutils-r1.eclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
> index 60f81473c0a..27bd9207743 100644
> --- a/eclass/distutils-r1.eclass
> +++ b/eclass/distutils-r1.eclass
> @@ -728,8 +728,8 @@ esetup.py() {
>  # to unmerge the package first.
>  #
>  # This function is not available in PEP517 mode.  The eclass provides
> -# a venv-style install unconditionally therefore, and therefore it
> -# should no longer be necessary.
> +# a venv-style install unconditionally and therefore it should no longer
> +# be necessary.
>  distutils_install_for_testing() {
>  	debug-print-function ${FUNCNAME} "${@}"
>  

Thanks for the patch.  While this is definitely good, I'm a bit
reluctant to force the big cache regen for this, so I'd rather wait till
we have some more changes in queue.  I'm a bit afraid I won't remember
about it though.

-- 
Best regards,
Michał Górny


[prev in list] [next in list] [prev in thread] [next in thread]