[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH 06/15] unpacker.eclass: Use lowercase in unpacker_src_uri_depends
From:       John Helmert III <ajak () gentoo ! org>
Date:       2022-09-25 21:06:01
Message-ID: YzDCuWZarVjA7JX8 () gentoo ! org
[Download RAW message or body]


On Sun, Sep 25, 2022 at 04:04:07PM -0500, John Helmert III wrote:
> On Sun, Sep 25, 2022 at 08:23:08PM +0200, Michał Górny wrote:
> > Transform the URIs to lowercase in unpacker_src_uri_depends() for
> > consistency with the behavior of _unpacker().
> > 
> > Signed-off-by: Michał Górny <mgorny@gentoo.org>
> > ---
> >  eclass/unpacker.eclass | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/eclass/unpacker.eclass b/eclass/unpacker.eclass
> > index 482cf141ee1d..e07c25d0ffa9 100644
> > --- a/eclass/unpacker.eclass
> > +++ b/eclass/unpacker.eclass
> > @@ -509,7 +509,8 @@ unpacker_src_uri_depends() {
> >  	fi
> >  
> >  	for uri in "$@" ; do
> > -		case ${uri} in
> > +		local m=${uri,,}
> > +		case ${m} in
> >  		*.cpio.*|*.cpio)
> >  			d="app-arch/cpio" ;;
> >  		*.rar|*.RAR)
> 
> If m is always lowercased, no need to check for uppercased extensions?

Sorry, this was done in the next patch

> 
> > -- 
> > 2.37.3
> > 
> > 



["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]