[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    [gentoo-dev] Re: [PATCH v4 0/2] *** rocm.eclass: new eclass ***
From:       Ulrich Mueller <ulm () gentoo ! org>
Date:       2022-08-28 6:36:33
Message-ID: uler8ri1a () gentoo ! org
[Download RAW message or body]


>>>>> On Sun, 28 Aug 2022, Yiyang Wu wrote:

> -		if has ${gpu_target} "${OFFICIAL_AMDGPU_TARGETS[*]}"; then
> +		if has "${gpu_target}" ${OFFICIAL_AMDGPU_TARGETS[*]}; then

This still doesn't look right. It should be:

		if has "${gpu_target}" "${OFFICIAL_AMDGPU_TARGETS[@]}"; then

From=20Bash documentation:

| If the word is double-quoted, '${NAME[*]}' expands to a single word
| with the value of each array member separated by the first character
| of the 'IFS' variable, and '${NAME[@]}' expands each element of NAME
| to a separate word.

Ulrich

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]