[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH 09/11] net-wireless/blueman: Invoke eautomake to fix py-compile script
From:       Ulrich Mueller <ulm () gentoo ! org>
Date:       2022-07-29 12:59:09
Message-ID: u35ekvzvm () gentoo ! org
[Download RAW message or body]


>>>>> On Fri, 29 Jul 2022, Michał Górny wrote:

> --- a/net-wireless/blueman/blueman-2.3.1.ebuild
> +++ b/net-wireless/blueman/blueman-2.3.1.ebuild
> @@ -97,7 +97,7 @@ pkg_setup() {
>  }
>  
>  src_prepare() {
> -	[[ ${PV} == 9999 ]] && eautoreconf
> +	[[ ${PV} == 9999 ]] && eautoreconf || eautomake

So if eautoreconf returns with nonzero status, eautomake will be called?
Or does eautoreconf always return zero (I believe it does)?

However, I don't want to think about that when reading the code, so
could you make it an if-then-else statement instead?

Same for the live ebuild.

Ulrich

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]