[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH] java-vm-2.eclass: use "eselect java-vm update" if available
From:       Florian Schmaus <flow () gentoo ! org>
Date:       2022-06-28 7:03:22
Message-ID: d1bd0432-e8ca-5ca2-6758-71d71c2189ae () gentoo ! org
[Download RAW message or body]

On 27/06/2022 21.39, Georgy Yakovlev wrote:
> On Mon, 2022-06-27 at 21:21 +0200, Florian Schmaus wrote:
>> Thanks to Mike Gilbert (floppym) for valuable feedback.
>>
>> Closes: https://bugs.gentoo.org/853928
>> Closes: https://github.com/gentoo/gentoo/pull/26069
>> Signed-off-by: Florian Schmaus <flow@gentoo.org>
>> ---
>>   eclass/java-vm-2.eclass | 30 ++++++++++++++++++++++++++++--
>>   1 file changed, 28 insertions(+), 2 deletions(-)
>>
>> diff --git a/eclass/java-vm-2.eclass b/eclass/java-vm-2.eclass
>> index 8196b1cdc72a..dc0d87f4caf5 100644
>> --- a/eclass/java-vm-2.eclass
>> +++ b/eclass/java-vm-2.eclass
>> @@ -25,6 +25,7 @@ RDEPEND="
>>   "
>>   DEPEND="${RDEPEND}"
>>   BDEPEND="app-arch/unzip"
>> +IDEPEND="app-eselect/eselect-java"
> 
> IDEPEND here will not do anything to current jdk source ebuilds.

Right, this is specified providently. I've updated the commit message of 
the change in the according pull request to make this more clear.

Also note that PMS does not guarantee that IDEPEND dependencies will be 
available in pkg_*rm phases.

But ultimately, declaring IDEPEND on eselect-java is the best thing we 
can do here.


> openjdk source ebuilds are EAPI7 at the moment and can't be updated to
> EAPI8 due to econf unconditionally passing '--disable-static'

I remember running into this when I tried to bump the JDK ebuilds to EAPI 8.

- Flow

[prev in list] [next in list] [prev in thread] [next in thread]