[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH 1/5] ninja-utils.eclass: Support dev-util/samurai
From:       Mike Gilbert <floppym () gentoo ! org>
Date:       2022-05-30 20:56:16
Message-ID: CAJ0EP40cMbdS9MtXt2_Uvu22wv5bseATSZ8kZD_V3-5Zmcf7RQ () mail ! gmail ! com
[Download RAW message or body]

On Mon, May 30, 2022 at 3:57 PM Anna "CyberTailor"
<cyber+gentoo@sysrq.in> wrote:
>
> On 2022-05-08 23:07, Sam James wrote:
> > From: orbea <orbea@riseup.net>
> >
> > samurai is a ninja-compatible build tool written in C which
> > works with cmake, meson and other users of ninja.
> >
> > It is feature-complete and supports most of the same options
> > as ninja.
> >
> > Signed-off-by: orbea <orbea@riseup.net>
> > Signed-off-by: Sam James <sam@gentoo.org>
> > ---
> >  eclass/ninja-utils.eclass | 24 +++++++++++++++++++++++-
> >  1 file changed, 23 insertions(+), 1 deletion(-)
> >
> > diff --git a/eclass/ninja-utils.eclass b/eclass/ninja-utils.eclass
> > index c5f34934192f..67f7a6b5e8a7 100644
> > --- a/eclass/ninja-utils.eclass
> > +++ b/eclass/ninja-utils.eclass
> > @@ -26,6 +26,15 @@ esac
> >  if [[ -z ${_NINJA_UTILS_ECLASS} ]]; then
> >  _NINJA_UTILS_ECLASS=1
> >
> > +# @ECLASS_VARIABLE: NINJA
> > +# @PRE_INHERIT
>
> How about making it @USER_VARIABLE instead? Because it's more likely to
> be set in make.conf rather than in an ebuild.

It's "unofficially" supported as a user variable. If users set it in
make.conf, it will break metadata invariance and the dependency cache
will need to be rebuilt.

If we truly want to support it as a user variable, we need to provide
some alternate means of varying BDEPEND.

[prev in list] [next in list] [prev in thread] [next in thread]